Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bold doesn't work in Creator's Update Bash #2027

Closed
agocke opened this issue Apr 27, 2017 · 7 comments
Closed

Bold doesn't work in Creator's Update Bash #2027

agocke opened this issue Apr 27, 2017 · 7 comments
Labels

Comments

@agocke
Copy link
Member

agocke commented Apr 27, 2017

Repro: echo -e "text \033[1mbold\033[0m text"

This prints the following for me:

image

bold should actually be bold, not just another color in the color palette. It also shouldn't change the foreground color.

Microsoft Windows [Version 10.0.15063]

@sunjoong
Copy link

@agocke - lt looks not bold but bright. Effect of code 1 is "Bold or increased intensity -- ANSI escape code".

@zadjii-msft
Copy link
Member

@agocke that's exactly right. We don't support proper bold at the moment, but the intensity works just fine for now. Like with all feature requests, it's already on the backlog :)

@agocke
Copy link
Member Author

agocke commented Apr 27, 2017

@zadjii-msft How do you decide what "intensity" means in this context? It seems to pick a different color from the palette, i.e. I can actually change the color that is printed by bold and it can be completely different from the normal color.

This is important because if I change the color scheme for my 8 foreground colors, what happens to my bold colors? It seems like sometimes nothing may happen, which means the bold colors show up as unreadable in my new color scheme.

@fpqc
Copy link

fpqc commented Apr 28, 2017

@agocke This is pretty standard for terminal emulators. The 'bright' colors are the second row of 8 colors in programs that have a sane color picking interface =p.

@agocke
Copy link
Member Author

agocke commented Apr 28, 2017

Yeah, I think I screwed up the transcription from my .Xresources. Still, bold would be useful.

@dgilmour77
Copy link

This creates a bit of a trap for unwary users. I like black text on dark grey background, and when I set it, it looked great. Until I brought up a man page and it looked garbled and broken because I was unlucky that the bold color automatically chosen was the same as my background color - dark grey. At a minimum, the logic for choosing a bold color should be based not just on the foreground color but the foreground/background combination. Yeah, good luck with that ;-)

@bitcrazed
Copy link
Contributor

This issue was moved to microsoft/terminal#109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants