Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure App Service + Cosmos form - missing error message on empty site name #1048

Closed
jsondoo opened this issue Aug 8, 2019 · 3 comments
Closed

Azure App Service + Cosmos form - missing error message on empty site name #1048

jsondoo opened this issue Aug 8, 2019 · 3 comments
Assignees
@prupipho
Labels
bug Something is broken Wizard Wizard issue
Milestone
0.7

Comments

@jsondoo
Copy link

jsondoo commented Aug 8, 2019 •
edited by prupipho
Loading

Currently if the name field is empty, there is no message, we just show a spinner. We should provide some feedback with a message like "Name cannot be empty"

image

Current Status:
AzureNameMessage
@jsondoo jsondoo added enhancement Improving an existing feature Wizard Wizard issue labels Aug 9, 2019
@prupipho
Copy link
Contributor

Still happening something similar. No message if you empty the Name box in both App Service or Cosmos Modal.
It doesn´t allow you to continue but it doesn´t display any error message or provide any feedback to know what to do next.

image

Could be an easy one to fit within next milestone @sibille ? As we are still refactoring and changing the Azure section?

@sibille
Copy link
Collaborator

sibille commented Oct 21, 2020

Agree, an empty name should show an error message here

@sibille sibille added this to the 0.6 milestone Oct 21, 2020
@sibille sibille added bug Something is broken and removed enhancement Improving an existing feature labels Oct 21, 2020
@prupipho prupipho modified the milestones: 0.6, 0.7 Nov 11, 2020
@sibille sibille changed the title Azure form - empty name field should give more feedback Azure App Service + Cosmos form - missing error message on empty site name May 11, 2021
@prupipho prupipho self-assigned this May 19, 2021
@prupipho prupipho added the In Progress Indicates the issue is currently being worked on label May 20, 2021
@prupipho prupipho mentioned this issue May 20, 2021
Merged
@prupipho prupipho added Ready for Testing and removed In Progress Indicates the issue is currently being worked on labels May 20, 2021
@prupipho
Copy link
Contributor

Tested on nightly version:
Templates version: 0.3.21167.1
Wizard version: 0.3.2116701

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prupipho prupipho

Labels
bug Something is broken Wizard Wizard issue
Projects
None yet
Milestone
0.7
Development

No branches or pull requests
3 participants
@prupipho @jsondoo @sibille