CGImages loaded from container data (JPEG, PNG, TIFF) can use-after-free their buffers.

[DHowett-MSFT]

In CGImage here, we specify OnDemand caching for images loaded from WIC frame decoders.

Unfortunately, if you do this:

CFDataRef data = CFDataCreate(...);
CGImageRef image = CGImageCreateWithDataProvider(CGDataProviderCreateWithCFData(data), ...);
CFRelease(data);
CGImageDoAnythingAtAll(image);

Line 4 will cause CGImage through WIC to read the buffer backing the CGData destroyed on line 3.

Interim solution: Switch to OnLoad.

Suggested future solution: Implement an IWICStream that is backed by a CGDataProvider.

[DHowett-MSFT]

As part of the aforementioned future solution, we could switch back to OnDemand (and reap all the savings.)

[msft-Jeyaram]

Saw this issue when we did bitmap context, made these changes in bitmap context. missed the decoder one.
Updating

[DHowett-MSFT]

Definitely don't do it tonight! I've worked around it for CoreGraphics.Drawing.UnitTests.

[msft-Jeyaram]

LOL so the existing CGImage tests would of got this easily, but we autoreleased the CFData, rather than a release right away.

[msft-Jeyaram]

#1413