Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUN --mount support in Windows BuildKit #498

Closed
dev-adi-github-nuitka opened this issue May 20, 2024 · 9 comments
Closed

RUN --mount support in Windows BuildKit #498

dev-adi-github-nuitka opened this issue May 20, 2024 · 9 comments
Assignees
Labels

Comments

@dev-adi-github-nuitka
Copy link

dev-adi-github-nuitka commented May 20, 2024

The following comment written in the issue for adding Windows BuildKit support indicated that in the future, we might be able to expect support for caching RUN steps via the --mount option. However, I am still unable to use the --mount option for RUN commands in Windows. Is support for this planned?


A very quick poke around suggests this failure is coming from hcsshim, which at that point does not appear to be ready to accept a windows-layer mount to a mount-point in the container

That is correct, currently Windows only supports mounting physical/virtual devices and named pipes/host folders via VSMB. The default mount type on Linux when none is explicitly specified is bind. On Windows it's windows-layer. While bind mounts on Linux are common place and can be used in any number, on Windows, windows-layer have only ever been used as root filesystem mounts.

It may suffice to allow setting the mount type in llb state. But I have not looked too much into it. Will have a look soon. I suspect we'll hit this issue when enabling tests as well.

For me, the next step (with no particular timeframe) was to run-up the BuildKit integration tests and see what works and what doesn't.

That is already being worked on by @profnandaa (see moby/buildkit#4432) and there should be a number of PRs incoming that will at least hook up the test suite to the CI and lay the ground for enabling tests (some will already be enabled, some should run but require support - images, windows specific testing Dockerfiles, etc).

Originally posted by @gabriel-samfira in #34 (comment)

@dev-adi-github-nuitka dev-adi-github-nuitka closed this as not planned Won't fix, can't repro, duplicate, stale May 20, 2024
@dev-adi-github-nuitka dev-adi-github-nuitka changed the title RUN --mount support in Windows BuildKit Issue made in error May 20, 2024
@dev-adi-github-nuitka dev-adi-github-nuitka changed the title Issue made in error RUN --mount support in Windows BuildKit May 20, 2024
@profnandaa
Copy link
Member

Cross-linking moby/buildkit#4837

Copy link
Contributor

This issue has been open for 30 days with no updates.
@profnandaa, please provide an update or close this issue.

@profnandaa
Copy link
Member

Still on the backlog, will update when we have something working.

Copy link
Contributor

This issue has been open for 30 days with no updates.
@profnandaa, please provide an update or close this issue.

@profnandaa
Copy link
Member

Still on the backlog.

Copy link
Contributor

This issue has been open for 30 days with no updates.
@profnandaa, please provide an update or close this issue.

2 similar comments
Copy link
Contributor

This issue has been open for 30 days with no updates.
@profnandaa, please provide an update or close this issue.

Copy link
Contributor

This issue has been open for 30 days with no updates.
@profnandaa, please provide an update or close this issue.

@lucillex
Copy link
Contributor

Closing this as it's being tracked in the buildkit repo: moby/buildkit#4837

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants