Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparkle feed URL fails to redirect in some circumstances #1238

Closed
pilotmoon opened this issue Oct 21, 2019 · 3 comments
Closed

Sparkle feed URL fails to redirect in some circumstances #1238

pilotmoon opened this issue Oct 21, 2019 · 3 comments
Assignees
Labels
bug A bug or issue with App Center distribute Related to App Center's Distribution service

Comments

@pilotmoon
Copy link

pilotmoon commented Oct 21, 2019

As discussed in issue #202, the HockeyApp Sparkle feed URLs now redirect to the equivalent App Center feed.

However, depending on the form of the HTTP request used to access the Sparkle feed, the HockeyApp sparkle URL sometimes erroneously return a 200 OK with old data.

Specifically, as far as I can tell, it seems to depend on the contents of the Accept: header. These are the combinations I have tested.

Accept: Header Result Notes
Not present 200 OK and old data ❌ This it what happens when you naively curl the feed.
Accept: 301 redirect ✅
Accept: */* 200 OK and old data ❌ This accept header is used by some versions of Sparkle in the wild.

The specific feed URL I used for the tests above is https://rink.hockeyapp.net/api/2/apps/58adb6c5bea28ffe22f304f2f383d089.

Please note that this bug means that version of apps out in the wild (including my own) are unable to update.

@pilotmoon pilotmoon changed the title Sparkle feed redirect is only applied in some circumstances Sparkle feed URL fails to redirect in some circumstances Oct 21, 2019
@Oddj0b Oddj0b added bug A bug or issue with App Center distribute Related to App Center's Distribution service labels Oct 22, 2019
@Oddj0b
Copy link
Contributor

Oddj0b commented Oct 22, 2019

Thanks for reporting the bug @invariant. Please allow some time because of time zones for my colleagues to look into it.

@Soph
Copy link
Member

Soph commented Oct 22, 2019

@invariant Thanks for reporting this. We rolled out a fix and the redirect should now also work in the case the feed is requested for a macOS app but no accept headers are send. Please let us know if you see any issues.

@pilotmoon
Copy link
Author

Just tested now, the redirect is working and my problem is solved. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug or issue with App Center distribute Related to App Center's Distribution service
Projects
None yet
Development

No branches or pull requests

5 participants