Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ProGuard mapping.txt file available #130

Closed
hsc-alexe opened this issue Feb 28, 2019 · 9 comments
Closed

Make ProGuard mapping.txt file available #130

hsc-alexe opened this issue Feb 28, 2019 · 9 comments
Assignees
Labels
build Related to App Center's Build service feature request New feature request

Comments

@hsc-alexe
Copy link

Describe the solution you'd like
On any completed App Center build, I would like the ability to download the ProGuard mappings.txt file associated with that build.

Describe alternatives you've considered
Not using App Center for release builds?

Additional context
Our Android team has integrated with App Center & set up a release process that gets triggered when we push to a specific branch. This then creates an Alpha release in the Play Store, which we promote through the pipeline to production if everything goes well. The issue is that we use ProGuard to obfuscate our apk, but App Center doesn't provide a way for us to download that file so that we can deobfuscate our crashes & logs. This is frankly not a world we can live in long-term, and although I am requesting this as a feature since it sounds like you haven't ever supported this functionality, it feels like a fairly severe bug in the system if you are truly offering a CI/CD solution.

@hsc-alexe hsc-alexe added the feature request New feature request label Feb 28, 2019
@patniko patniko added the build Related to App Center's Build service label Mar 1, 2019
@patniko
Copy link
Contributor

patniko commented Mar 1, 2019

Thanks for the request @hsc-alexe! We do support proguard deobfuscation with our diagnostics service - are you using an alternative product for crash information?

@hsc-alexe
Copy link
Author

hsc-alexe commented Mar 1, 2019

@patniko My understanding is that you support proguard deobfuscation by uploading a mappings.txt file in your diagnostics tool, correct? The problem is that I don't actually have access to that file for builds run by App Center.

@patniko
Copy link
Contributor

patniko commented Mar 1, 2019

You're correct. We don't do it today, but could always automatically send mapping files from our build to the service so you wouldn't have to download and re-upload them. Would that be a better option for you?

@hsc-alexe
Copy link
Author

I would see that as a nice-to-have to make the App Center use-case better. The Play Store also has diagnostics tools and we send some of our data to other 3p services, so being able to download the file is still more important to me. As a consumer, I would like the ability to be able to select the diagnostics/analytics tools we want to use, independent of the CI system we use. If App Center's tools are the best and the easiest to use, then great we will gladly use them, but forcing us into one ecosystem by not allowing us to deobfuscate our own code does not seem very customer-centric.

@patniko
Copy link
Contributor

patniko commented Mar 4, 2019

We agree with that sentiment! Appreciate the clarity so we can hone in on the specific requirements.

@chrisseed
Copy link

We don't do it today, but could always automatically send mapping files from our build to the service so you wouldn't have to download and re-upload them.

My scenario is very similar to @hsc-alexe's - we use the Build service to build a Xamarin project and push it to Play's Alpha channel. In our case, we are sending diagnostics data back to App Center so being able to download the mappings.txt is a nice to have, but really we need the mappings file to be automatically uploaded to Diagnostics for us.

Appreciate this is a slightly different feature request but given @patniko just mentioned exactly the solution we are after I thought I would add my comment here.

To second @hsc-alexe's point, App Center is currently pushing us away from using its own Diagnostics service because we can't de-obfuscate our stack traces which seems bizarre.

@ddui
Copy link

ddui commented Apr 23, 2019

We have exactly the same requirement as @hsc-alexe. It would be great if this feature was fast tracked as it would be a very common request for many security conscious Android developers. @winnieli1208, @patniko, @nrajpurkar when do you think it could potentially make a release?

@mikekpl
Copy link

mikekpl commented Apr 24, 2019

To add, hopefully the error logs / crash logs on Diagnostics feature should not be obfuscated any more, to be more visible with the crashes, since the mapping file itself is already in the AppCenter Builds / Diagnostics.

@blparr blparr mentioned this issue May 28, 2019
18 tasks
@nilofer
Copy link

nilofer commented Jun 4, 2019

Downloading the mapping file after a build is now available! Check it out and let us know if you have any issues. Note: you many need to re-save your build configuration for existing configurations for this to work.

@nilofer nilofer closed this as completed Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to App Center's Build service feature request New feature request
Projects
None yet
Development

No branches or pull requests

7 participants