Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D8/R8 Support #698

Closed
NunoBem opened this issue Jul 11, 2019 · 11 comments
Closed

D8/R8 Support #698

NunoBem opened this issue Jul 11, 2019 · 11 comments
Assignees
Labels
feature request New feature request

Comments

@NunoBem
Copy link

NunoBem commented Jul 11, 2019

Describe the solution you'd like
After migrating our app from DX/Proguard to D8/R8, the app had several problems. Contacting AppCenter chat, I was informed that it isn't supported and to open a new feature request.

R8 became the default code shrinker for Android and should be supported.

Describe alternatives you've considered
Building the apk on our Visual Studio, results in a working app. But breaks our CI/CD.

@NunoBem NunoBem added the feature request New feature request label Jul 11, 2019
@winnie
Copy link

winnie commented Jul 17, 2019

Hi @NunoBem - thanks for the feature request. App Center diagnostics only supports deobfuscation with the ProGuard at the moment. We don't have immediate plans to support D8/R8 but I will monitor this request for interest.

(Note: similar request #458)

@filipkowicz
Copy link

D8/R8 is becoming standard in Android world. @winnieli1208 please consider supporting it soon

@brcinho
Copy link

brcinho commented Jul 25, 2019

Since R8 is becoming de-facto standard from Android side, and is supposed to replace proguard. In recent versions of Android Studio and gradle it is enabled by default. I suppose that tells you that there will be interest for this.

Why the need to explicitly show the interest with comments and up-votes?

@NunoBem
Copy link
Author

NunoBem commented Jul 25, 2019

Contacting AppCenter chat, I was informed that it isn't supported and to open a new feature request.

@brcinho I suppose microsoft is driven by community feedback too and defines it's priorities.

@brcinho
Copy link

brcinho commented Jul 26, 2019

@NunoBem I completely agree with you. The problem occurs when someone is shutting down the service to push their own service but they didn't match the quality, pro-activeness and feature set of the previous service. Then they can not rely that product roadmap depends on the community feedback solely, they need to show some initiative and pro-activeness on their own.

@matthiaswenz
Copy link

@NunoBem Were your problems with R8/D8 related to only building your app on App Center or also diagnosing crash reports? I'll look into the conversations on why it might have failed for you, but feel free to share more details here or with me personally (email is in bio) if needs be - at least in general it should work for App Center Build.

@brcinho
Copy link

brcinho commented Aug 14, 2019

@ranterle Related to inability for app center to de-obfuscate the stack trace based on the mapping.txt uploaded.

@brcinho
Copy link

brcinho commented Aug 14, 2019

#458

@NunoBem
Copy link
Author

NunoBem commented Oct 2, 2019

What's the feedback about this? @winnieli1

@winnie
Copy link

winnie commented Nov 7, 2019

Hi all! Our team is starting this very soon. No exact ETA yet but we expect to have this done in a few
weeks. Thanks for the patience! We'll post here with updates.

@winnie
Copy link

winnie commented Nov 20, 2019

We added support for this last week (see #458). Thanks!

@winnie winnie closed this as completed Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature request
Projects
None yet
Development

No branches or pull requests

5 participants