Skip to content

Commit 64cf769

Browse files
Copilotekzhu
andcommitted
Fix pyright errors in reasoning_effort tests by adding ignore comments for private usage
Co-authored-by: ekzhu <320302+ekzhu@users.noreply.github.com>
1 parent 7658f86 commit 64cf769

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

python/packages/autogen-ext/tests/models/test_openai_model_client.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3281,7 +3281,7 @@ async def test_reasoning_effort_parameter() -> None:
32813281
api_key="fake_key",
32823282
reasoning_effort="low",
32833283
)
3284-
assert openai_client._create_args["reasoning_effort"] == "low"
3284+
assert openai_client._create_args["reasoning_effort"] == "low" # pyright: ignore[reportPrivateUsage]
32853285

32863286
# Test Azure OpenAI client with reasoning_effort
32873287
azure_client = AzureOpenAIChatCompletionClient(
@@ -3292,7 +3292,7 @@ async def test_reasoning_effort_parameter() -> None:
32923292
api_key="fake_key",
32933293
reasoning_effort="medium",
32943294
)
3295-
assert azure_client._create_args["reasoning_effort"] == "medium"
3295+
assert azure_client._create_args["reasoning_effort"] == "medium" # pyright: ignore[reportPrivateUsage]
32963296

32973297
# Test load_component with reasoning_effort for OpenAI
32983298
from autogen_core.models import ChatCompletionClient
@@ -3307,8 +3307,8 @@ async def test_reasoning_effort_parameter() -> None:
33073307
}
33083308

33093309
loaded_openai_client = ChatCompletionClient.load_component(openai_config)
3310-
assert loaded_openai_client._create_args["reasoning_effort"] == "high"
3311-
assert loaded_openai_client._raw_config["reasoning_effort"] == "high"
3310+
assert loaded_openai_client._create_args["reasoning_effort"] == "high" # pyright: ignore[reportPrivateUsage, reportUnknownMemberType, reportAttributeAccessIssue]
3311+
assert loaded_openai_client._raw_config["reasoning_effort"] == "high" # pyright: ignore[reportPrivateUsage, reportUnknownMemberType, reportAttributeAccessIssue]
33123312

33133313
# Test load_component with reasoning_effort for Azure OpenAI
33143314
azure_config = {
@@ -3324,13 +3324,13 @@ async def test_reasoning_effort_parameter() -> None:
33243324
}
33253325

33263326
loaded_azure_client = ChatCompletionClient.load_component(azure_config)
3327-
assert loaded_azure_client._create_args["reasoning_effort"] == "low"
3328-
assert loaded_azure_client._raw_config["reasoning_effort"] == "low"
3327+
assert loaded_azure_client._create_args["reasoning_effort"] == "low" # pyright: ignore[reportPrivateUsage, reportUnknownMemberType, reportAttributeAccessIssue]
3328+
assert loaded_azure_client._raw_config["reasoning_effort"] == "low" # pyright: ignore[reportPrivateUsage, reportUnknownMemberType, reportAttributeAccessIssue]
33293329

33303330
# Test serialization and deserialization
33313331
config_dict = openai_client.dump_component()
33323332
reloaded_client = OpenAIChatCompletionClient.load_component(config_dict)
3333-
assert reloaded_client._create_args["reasoning_effort"] == "low"
3333+
assert reloaded_client._create_args["reasoning_effort"] == "low" # pyright: ignore[reportPrivateUsage]
33343334

33353335

33363336
@pytest.mark.asyncio
@@ -3342,9 +3342,9 @@ async def test_reasoning_effort_validation() -> None:
33423342
client = OpenAIChatCompletionClient(
33433343
model="gpt-5",
33443344
api_key="fake_key",
3345-
reasoning_effort=valid_value,
3345+
reasoning_effort=valid_value, # pyright: ignore[reportArgumentType]
33463346
)
3347-
assert client._create_args["reasoning_effort"] == valid_value
3347+
assert client._create_args["reasoning_effort"] == valid_value # pyright: ignore[reportPrivateUsage]
33483348

33493349
# Test None value (should be included if explicitly set)
33503350
client_with_none = OpenAIChatCompletionClient(
@@ -3353,14 +3353,14 @@ async def test_reasoning_effort_validation() -> None:
33533353
reasoning_effort=None,
33543354
)
33553355
# When explicitly set to None, it will be included in create_args
3356-
assert client_with_none._create_args["reasoning_effort"] is None
3356+
assert client_with_none._create_args["reasoning_effort"] is None # pyright: ignore[reportPrivateUsage]
33573357

33583358
# Test not providing reasoning_effort (should not be in create_args)
33593359
client_without_reasoning = OpenAIChatCompletionClient(
33603360
model="gpt-5",
33613361
api_key="fake_key",
33623362
)
3363-
assert "reasoning_effort" not in client_without_reasoning._create_args
3363+
assert "reasoning_effort" not in client_without_reasoning._create_args # pyright: ignore[reportPrivateUsage]
33643364

33653365
# Test invalid value via load_component (Pydantic validation)
33663366
from pydantic import ValidationError

0 commit comments

Comments
 (0)