[Functions] Do not run func extensions install when using extension bundles

[pragnagopa]

Plugin name and version

Functions

Related archetype update: microsoft/azure-maven-archetypes#108

If an app is using bundles, do not run func extensions install . This will eliminate the requirement for dotnet core / func cli at the app creation time.

cc: @soninaren @jeffhollan @mattchenderson

@jdneo / @Flanker32 - Please let us know if you have any questions.

[Flanker32]

@pragnagopa Sorry for reply late, so the maven plugin should detect whether the project using bundles and decide whether to execute func extensions install? Is there any schema here, or we just need to check extensionBundle exist in host.json?

[pragnagopa]

Is there any schema here, or we just need to check extensionBundle exist in host.json?

Yes you need to check host.json if the app is using extension bundle.

@soninaren - Can you please paste a sample host.json?

[pragnagopa]

@soninaren will be updating CLI to take care of this scenario. Please hold off on this item until we have new CLI.

[pragnagopa]

cc @amamounelsayed

@Flanker32 - Can you please verify if this issue is already addressed?

[Flanker32]

@pragnagopa We are not aware of the status of extension bundles and function core tools and this issue is still in backlog.

Besides, does this issue depends on #658?

[pragnagopa]

@Flanker32 - this is unrelated to issue #658

if an app is using extension bundles, mvn plugin should not run function extensions install explicitly. @soninaren - Are we still waiting on CLI updates?

[soninaren]

@pragnagopa The CLI updates required for this use are complete.

Here is the sample host.json file. You need to only check for the id property since the version can change.

{
    "version": "2.0",
    "extensionBundle": {
        "id": "Microsoft.Azure.Functions.ExtensionBundle",
        "version": "[1.*, 2.0.0)"
    }
}

[daniel-rocha]

Is there any way for me to test this change?

[soninaren]

@daniel-rocha This is an optimization to make sure we don't call func extensions install where we don't need. To test this change, Once the plugin has been updated execute the run command and check if the maven plugin is calling func extensions install

[daniel-rocha]

@soninaren right. is there an internal repo where a new version of the plugin is updated?

[soninaren]

@daniel-rocha. I don't know if we stage the mvn plugin for testing before we release to production, @Flanker32 or @pragnagopa might be able to answer this.

[Flanker32]

@soninaren Before release to production, we will release it to staging repo first for test purpose, i'll share the access once it is done.

[Flanker32]

Fixed in #771, will skip func install when there are function bundles in host.json

[soninaren]

Oldest CLI version that supported bundles is 2.6.666 in case you still need it.

[Flanker32]

Oldest CLI version that supported bundles is 2.6.666 in case you still need it.

@soninaren Thanks for the information, i wonder whether we should show an info when user install the cli with lower version, for they may not be able to run it locally.

[pragnagopa]

@Flanker32 - Is this issue addressed? Can it be closed?

[Flanker32]

@pragnagopa This has been done in #771, but the pr of archetype is pending for @mattchenderson said a few other bundles dependencies will come together. Is this job done? So that we could merge the archetype pr and close this issue.

[Flanker32]

@pragnagopa This has been released with azure functions maven plugin 1.3.4, so close it.