Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom cloud providers #23205

Closed
cheenamalhotra opened this issue May 24, 2023 · 3 comments · Fixed by #23390
Closed

Add support for custom cloud providers #23205

cheenamalhotra opened this issue May 24, 2023 · 3 comments · Fixed by #23390
Assignees
Labels
Area - Azure Enhancement Request for new features or functionality Size: L For a large complexity issue - only when fixed with a PR Triage: Done

Comments

@cheenamalhotra
Copy link
Member

It maybe useful to allow user to provide settings for their cloud provider (one or multiple) when authenticating with AAD, by accepting below info:

The cloud owners can authorize ADS' app ID as needed and enable authentication support on their end, to bring experience similar to SSMS:

image

Proposed solution:
New setting is introduced that accepts JSON object array for provider settings and if that's provided, the clouds gets appended to the list of clouds supports by ADS.

@cheenamalhotra cheenamalhotra added Area - Azure Enhancement Request for new features or functionality Triage: Done labels May 24, 2023
@Charles-Gagnon
Copy link
Contributor

While you're at it, refactoring the cloud settings to not be checkboxes for enabling each cloud would be fantastic. Choosing the current cloud from a list makes a lot more sense given that we only allow one at a time anyways.

@cheenamalhotra
Copy link
Member Author

We do allow and work with multiple clouds btw. Users get to choose which cloud to use for adding account from selector.

@Charles-Gagnon
Copy link
Contributor

Oh neat, somehow I missed that. Carry on then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area - Azure Enhancement Request for new features or functionality Size: L For a large complexity issue - only when fixed with a PR Triage: Done
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants