Sql Authentication Provider breaks login

[scottrudy]

• Azure Data Studio Version: 1.44.0
• OS Version: Version 22H2 (OS Build 19045.2965)

Steps to Reproduce:

1. Upgrade from version 1.43.0 to 1.44.0
2. Try to login to a database using "Azure Active Directory - Universal with MFA support"
3. Get message, Invalid email address format for user: [Department)] received for Azure Active Directory authentication.
   • Important: the display name of the user is in the format "LastName, FirstName :(Role - Department)"
   • The email address is in the format firstname.lastname@domain.com and the UPN is in the format account@otherdomain.com

Does this issue occur when all extensions are disabled?: Yes

I'm guessing this has to do with the display name having a dash. I imagine Studio is trying to get the UPN for login by looking for the first "-" and it should be looking for the last instance of the "-" in that string. Note that disabling SQL Authentication Provider allows for a workaround.

1-Azure Accounts.log

[github-actions]

We need more info to debug your Azure Active Directory issue. If you could attach your logs to the issue (ensure no private data is in them), it would help us fix the issue much faster.

• In the settings menu, find the setting titled Azure: Logging Level and select the Verbose option
• Run the process that produces your error
• Open command palette (Click View -> Command Palette)
• Run the command: Developer: Open Logs Folder
• Follow this path to find the Azure Accounts log file: [default log folder]/exthost1/output_logging_[earliest timestamp]/#-Azure Acounts.log
• Please attach the Azure-Accounts.log file to the issue.

[cheenamalhotra]

I believe this is a special scenario and can be fixed by ensuring we capture the last index of ' - '. Thanks for letting us know!

You may continue to use workaround in the meantime.

[scottrudy]

I did the steps for logging anyway, but even after encountering the error the Azure Accounts.log file is empty.

[cheenamalhotra]

You may need to reload Azure Data Studio to allow setting to take effect.

[darknoon29]

Same issue on my side with an email account using the following format: xxxx-yyyyyyyyy@tenant.onmicrosoft.com

[jk-at-kf]

I'm getting that as well format is: q-myname@mycompany.com