Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Insight dialog bugs #2590

Closed
4 tasks done
abist opened this issue Sep 14, 2018 · 0 comments
Closed
4 tasks done

Dashboard: Insight dialog bugs #2590

abist opened this issue Sep 14, 2018 · 0 comments

Comments

@abist
Copy link
Contributor

abist commented Sep 14, 2018

  • SQL Operations Studio Version: master

Steps to Reproduce:

  1. Open any server dashboard.
  2. Edit the Backup widget by clicking on the ... button on the top right of the widget and click on Show Details.

Expected - A list of Items and corresponding Item Details should be open in the Insights Dialog
Actual -

  • A list of items show up but the Item Details is collapsed. Screenshot -

collapsed

  • Clicking on Item Details send Item Details to the bottom. Needs to be clicked again so that it pops out. Screenshot -

capture1

  • Item Details does not change when an item from the Item list is highlighted or focused.
    capture2

It needs to be clicked twice again (because of bug #2 where Item Details just sits at the bottom) to update.

  • Critical
    Pressing Esc when there's focus on any of the items in the Items list in the Insight Dialog will crash the app with the following error -
TypeError: Cannot read property 'style' of null
    at Builder.doSetStyle (Users/adbist/Desktop/SQL_Tools/sqlopsstudio/out/vs/base/browser/builder.js:482)
    at Builder.style (Users/adbist/Desktop/SQL_Tools/sqlopsstudio/out/vs/base/browser/builder.js:469)
    at Button.applyStyles (Users/adbist/Desktop/SQL_Tools/sqlopsstudio/out/vs/base/browser/ui/button/button.js:100)
    at Users/adbist/Desktop/SQL_Tools/sqlopsstudio/out/sql/base/browser/ui/modal/modal.js:240
    at Array.forEach (<anonymous>)
    at InsightsDialogView.Modal.hide (Users/adbist/Desktop/SQL_Tools/sqlopsstudio/out/sql/base/browser/ui/modal/modal.js:240)
    at InsightsDialogView.close (Users/adbist/Desktop/SQL_Tools/sqlopsstudio/out/sql/parts/insights/browser/insightsDialogView.js:293)
    at InsightsDialogView.onClose (Users/adbist/Desktop/SQL_Tools/sqlopsstudio/out/sql/parts/insights/browser/insightsDialogView.js:298)
    at HTMLDocument.<anonymous> (Users/adbist/Desktop/SQL_Tools/sqlopsstudio/out/sql/base/browser/ui/modal/modal.js:220)

instead of closing the dialog.

@kburtram kburtram added this to the September Release milestone Sep 14, 2018
@abist abist closed this as completed Sep 17, 2018
@adsbot adsbot bot locked and limited conversation to collaborators Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants