Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Electron 30+ #25938

Open
JustinGrote opened this issue Sep 24, 2024 · 1 comment
Open

Update to Electron 30+ #25938

JustinGrote opened this issue Sep 24, 2024 · 1 comment

Comments

@JustinGrote
Copy link

JustinGrote commented Sep 24, 2024

Azure Data studio is still running on electron 25. Electron 25 has been EOL for 9 months now and has several high and critical severity outstanding vulnerabilities that will never be fixed. Extensions such as the PowerShell extension that support Azure Data Studio also cannot update from the underlying nodejs version and are at risk for the same vulnerabilities.

Please consider updating to at least Electron 30.4.0 which is what the current version of VSCode uses, I imagine with that user base it has been proven stable enough :).

@JustinGrote
Copy link
Author

For example, the PowerShell extension is forced to use these unsupported engines due to maintaining Azure Data Studio Support

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@vscode/vsce@3.1.0',
npm WARN EBADENGINE   required: { node: '>= 20' },
npm WARN EBADENGINE   current: { node: 'v18.15.0', npm: '9.9.3' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'cheerio@1.0.0',
npm WARN EBADENGINE   required: { node: '>=18.17' },
npm WARN EBADENGINE   current: { node: 'v18.15.0', npm: '9.9.3' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'glob@11.0.0',
npm WARN EBADENGINE   required: { node: '20 || >=22' },
npm WARN EBADENGINE   current: { node: 'v18.15.0', npm: '9.9.3' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'minimatch@10.0.1',
npm WARN EBADENGINE   required: { node: '20 || >=22' },
npm WARN EBADENGINE   current: { node: 'v18.15.0', npm: '9.9.3' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'jackspeak@4.0.1',
npm WARN EBADENGINE   required: { node: '20 || >=22' },
npm WARN EBADENGINE   current: { node: 'v18.15.0', npm: '9.9.3' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'path-scurry@2.0.0',
npm WARN EBADENGINE   required: { node: '20 || >=22' },
npm WARN EBADENGINE   current: { node: 'v18.15.0', npm: '9.9.3' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'lru-cache@11.0.1',
npm WARN EBADENGINE   required: { node: '20 || >=22' },
npm WARN EBADENGINE   current: { node: 'v18.15.0', npm: '9.9.3' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'undici@6.19.8',
npm WARN EBADENGINE   required: { node: '>=18.17' },
npm WARN EBADENGINE   current: { node: 'v18.15.0', npm: '9.9.3' }
npm WARN EBADENGINE }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant