Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Results don't render - later appear in another tab incorrectly #5627

Open
joshbooker opened this issue May 24, 2019 · 10 comments
Open

Comments

@joshbooker
Copy link

joshbooker commented May 24, 2019

- Azure Data Version: 1.7.0 (system setup)
Commit: e128002
Date: 2019-05-08T00:55:40.928Z
VS Code 1.33.1
Electron: 3.1.8
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 6.1.7601

Steps to Reproduce:

  1. Open two queries in separate files such as:
    SELECT 'Query1' AS Query1, GETDATE() AS Stamp
    and
    SELECT 'Query3' AS Query3, GETDATE() AS Stamp
  2. Run each using same connection
  3. Eventually one of them fails to render results
    • not sure why or how to repeat 100%
    • appears to being long running but profile shows completed
    • cancel doesn't do anything
  4. Now close and reopen the same files and run with same connection.
  5. Boom - get mix of results from execution in step Update CONTRIBUTING.md #3.
    • notice date stamps appear as though data did come back properly step#3
    • notice column names and row results are from different executions.

screenshot

I will post a gif in a bit.

Josh

@joshbooker joshbooker added the Bug label May 24, 2019
@joshbooker joshbooker changed the title Query Results don't render later appear in another tab incorrectly Query Results don't render - later appear in another tab incorrectly May 24, 2019
@joshbooker
Copy link
Author

demo

@kburtram
Copy link
Member

@joshbooker thanks for the GIF! That really helps understand the issue better.

@kburtram kburtram added this to the Planning milestone May 24, 2019
@joshbooker
Copy link
Author

perhaps related:
#2694
#3868
#3627
#3653
#5606

@joshbooker
Copy link
Author

More info: the behavior starts by looking like a like a long running query - Run btn disabled, Cancel does nothing, no results ever render - sometimes the the execution timer is still running but Profiler shows successful completion. Disconnect and change connect works, but the weird part is when you close the file and open another file and execute with same connection. You get rows from current execute in columns from prior execution. It's like the results that never rendered before are rendered now except in columns from current exec. It gets really funky when the column counts don't match.

The results never rendering is common but the only way I can repeat the funky results is when I reopen a file.

@joshbooker
Copy link
Author

@kburtram You're welcome - spent half day on this repro and issue post...high hopes you'll fix asap so I can stop reverting to SSMS ;).

@aaomidi
Copy link
Contributor

aaomidi commented Aug 1, 2019

I was unable to repro this with the latest code on master.

@aaomidi aaomidi self-assigned this Aug 1, 2019
@joshbooker
Copy link
Author

@aaomidi This is still happening for me:

image

Version: 1.10.0-insider (system setup)
Commit: c4ab7f6
Date: 2019-08-02T07:46:26.791Z
VS Code 1.37.0
Electron: 4.2.7
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.17763

@joshbooker
Copy link
Author

joshbooker commented Aug 2, 2019

Same repro steps. Trick is to get one query to 'hang' somehow(?) - that query appears to run 'Executing query...' status indefinitely with timer running forever. Then close and reopen a different .sql file and execute to get the 'hung' query results in the other query pane. The only way I can repro this is after closing and reopening a .sql file from disk.

@aaomidi
Copy link
Contributor

aaomidi commented Aug 2, 2019

Thank you! Will look into this again!

@kburtram kburtram modified the milestones: Postponed, Planning Sep 16, 2019
@kburtram kburtram modified the milestones: Planning, Backlog Oct 24, 2019
@joshbooker
Copy link
Author

Has anyone been able to reproduce this? Still plagues me daily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

5 participants