Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

bedrock service install-build-pipeline is not validating the correct pipeline definition value #1405

Closed
mtarng opened this issue May 2, 2020 · 2 comments · Fixed by microsoft/bedrock-cli#39
Assignees
Labels
bug Something isn't working good first issue Good for newcomers high - pri

Comments

@mtarng
Copy link
Contributor

mtarng commented May 2, 2020

Describe the bug:
bedrock service install-build-pipeline is not validating the correct pipeline definition value
To Reproduce:

bedrock service create azure-vote azure-vote-app --helm-config-git https://github.com/mtarng/helm-charts.git --helm-config-branch master --helm-config-path chart-source/azure-vote
git commit -am 'Adding azure-vote'
git push
spk service install-build-pipeline azure-vote

should succeed, instead we get:

error:   
code: 1000
message: service-install-build-pipeline-cmd-failed: Service install build pipeline was not successfully executed.
  code: 1100
  message: git-azure-file-no-exist-in-repo: File azure-vote/build-update-hld.yaml did not exist in master branch in repository fabrikam2019.

Expected behavior:

Screenshots:

Additional context:
https://github.com/microsoft/bedrock-cli/blob/master/src/commands/service/pipeline.ts#L199-L203
This block should look up the service path and not use the service name.

Follow up question, should we remove the flag for a "packages" directory?

Does this require updates to documentation?:
No. Documentation is accurate, but service-path isn't.

@mtarng mtarng added the bug Something isn't working label May 2, 2020
@mtarng mtarng added this to the Service Management Automation milestone May 2, 2020
@mtarng
Copy link
Contributor Author

mtarng commented May 4, 2020

Follow up question, should we remove the flag for a "packages" directory? We are currently passing the full path to the service when running bedrock service create, the packages path flag may cause confusion.

Thoughts @andrebriggs @evanlouie @bnookala

@bnookala
Copy link
Member

bnookala commented May 4, 2020

@mtarng happy to remove it if it's not being used

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers high - pri
Projects
None yet
3 participants