Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Expression] Make Expression meet the requirement from Adaptive Card team #3249

Closed
4 tasks done
Danieladu opened this issue Jan 10, 2020 · 3 comments
Closed
4 tasks done
Assignees
Labels
composer Impacts composer P0 Must Fix. Release-blocker R8 Release 8 - March 16th, 2020
Milestone

Comments

@Danieladu
Copy link
Contributor

Danieladu commented Jan 10, 2020

We have some requirements from AdaptiveCards team.

  • ${} instead of @{} as bounding syntax.
  • + for concatenation. If either operand is a string, then + should do string concatenation and cast other operand to string.
  • move string interpolation into expressions (bring forward Tom's work into expressions so hosts do not have to repeat this)
  • namespace change. Overall brand: Adaptive Expressions; NuGet: AdaptiveExpressions; NpmJS: adaptive-expressions
@vishwacsena
Copy link
Contributor

@matthidinger were there other changes required? can you help summarize/ confirm the list above? We'd like to start work on this at least on the things that are PORs.

@matthidinger
Copy link
Member

The working document is here (internal link), but it would be great if we can regroup as I think some decisions are still pending. Are you folks available Weds at 3pm to dive into it? I can send the meeting invite

https://dev.azure.com/microsoft/AdaptiveCards/_git/Explorations?path=%2Fdocs%2FExplorations%2FTemplateLanguage%2FCommonExpressionLanguage.md&version=GBmaster&_a=preview

@vishwacsena
Copy link
Contributor

@boydc2014 we can start resourcing this. See list above. Let's use this ticket as a living tracking item as we find other things to do.

@tomlm @chrimc62 @matthidinger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
composer Impacts composer P0 Must Fix. Release-blocker R8 Release 8 - March 16th, 2020
Projects
None yet
Development

No branches or pull requests

5 participants