Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom functions are not resolved in imported .lg files #3492

Closed
chrimc62 opened this issue Mar 4, 2020 · 0 comments · Fixed by #3513
Closed

Custom functions are not resolved in imported .lg files #3492

chrimc62 opened this issue Mar 4, 2020 · 0 comments · Fixed by #3513
Assignees
@cosmicshuai
Labels
P0 Must Fix. Release-blocker R8 Release 8 - March 16th, 2020
Milestone
R8

Comments

@chrimc62
Copy link
Contributor

chrimc62 commented Mar 4, 2020

Describe the bug

Custom functions are not used when evaluating imported .lg files. This is fixed in the node version through this PR which also includes a test: microsoft/botbuilder-js#1845 The specific issue is that start.ExpressionEngine is not passed into ParseText inside ResolveImportResources.

Expected behavior

Custom functions should be allowed in imported .lg files.

[bug]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cosmicshuai cosmicshuai

Labels
P0 Must Fix. Release-blocker R8 Release 8 - March 16th, 2020
Projects
None yet
Milestone
R8
Development

Successfully merging a pull request may close this issue.

Port: refence a custom function in LG imports microsoft/botbuilder-dotnet
5 participants
@boydc2014 @cosmicshuai @chrimc62 @vishwacsena @munozemilio