Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BotFrameworkHttpClient should use its Logger #3823

Closed
stevengum opened this issue Apr 28, 2020 · 0 comments · Fixed by #4134
Closed

BotFrameworkHttpClient should use its Logger #3823

stevengum opened this issue Apr 28, 2020 · 0 comments · Fixed by #4134
Assignees
@mrivera-ms
Labels
Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. P1 Painful if we don't fix, won't block releasing R10 Release 10 - August 17th, 2020
Milestone
R10

Comments

@stevengum
Copy link
Member

The only place BotFrameworkHttpClient uses its Logger is when it creates AppCredentials via BuildCredentialsAsync.

In BotFrameworkAdapter.SendActivitiesAsync the bot logs when it's sending an activity, the BFHttpClient should do the same.

[enhancement]
@stevengum stevengum added enhancement R10 Release 10 - August 17th, 2020 labels Apr 28, 2020
@mrivera-ms mrivera-ms added the Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. label May 21, 2020
@axelsrz axelsrz added the P1 Painful if we don't fix, won't block releasing label Jun 15, 2020
@mrivera-ms mrivera-ms mentioned this issue Jun 19, 2020
Merged
@munozemilio munozemilio added this to the R10 milestone Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrivera-ms mrivera-ms

Labels
Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. P1 Painful if we don't fix, won't block releasing R10 Release 10 - August 17th, 2020
Projects
None yet
Milestone
R10
Development

Successfully merging a pull request may close this issue.

Add logging to BotFrameworkHttpClient.PostActivityAsync() microsoft/botbuilder-dotnet
4 participants
@axelsrz @stevengum @munozemilio @mrivera-ms