-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle EndOfConversation(EoC Activity) in Skills in Bot Composer #6705
Comments
Hi @Akhila9
Can you clarify on what you mean by this? Who is sending the EoC?
I don't know what you mean by instances, can you clarify. The conversation may be 'abandoned' in the skill, but the only thing that would affect is a very small state store bloat. |
EoC Activity is endOfConversation Activity. We are developing a audio bot, which is been integrated with third party service, so whenever the caller disconnect the call we get EoC Activity, but when the connection is in skill, this activity wont reach the skill bot. But as discussed earlier for events the control always goes through the root bot, though we have bypassed the EoC Activity in root bot, the control doesnt reach the skill bot, rather than that it will be treated as endOfConversation triggered to the root bot. If that happens, I assume that the skill bot instances will be open as autoEndDialog is false and occupying the memory space increasing CPU load and which in turn can lead to 504 timeout issues. I am not really sure about the understanding but assumes it happens in this way, can you please guide me on it. Our expected behaviour is that the EoC activity to be reached to skill bot, then we can end the dialog and send it to the root bot. From the current behaviour, I dont see any approach to do it, can you please suggest the best possible way to do it. |
@dmvtech, Hi Dana, if we want to discuss it over an meeting, if you can share your email and prefered time, I can book a slot. I am in IST zone and so till 11.00PM IST works for me. Thanks in advance. |
My case is a little different. These are the traces I read produced by the Composer: Passy.Bot.Composer Information: 0 : 12: 'endOfConversation' ==> activityReceived ==> SubmitActionPrompt |
As this is not possible in Composer, switching this over to a feature request. |
Describe the solution you'd likeWhen there is a Root bot calling a skill; when the Root bot receives a Additional contextSample activity being sent to the Root bot:
|
@dmvtech Can you please let me know the behaviour for EndOfConversation activity in Root and skill bots?
Let say if EoC Activity hits the root bot, we close the connection in the root bot, but the skill will be open and so instances will be running right? Wont that cause a problem?
The text was updated successfully, but these errors were encountered: