Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

[PORT] Update Facebook, Slack, Webex adapters #660

Closed
tomlm opened this issue Jul 1, 2020 · 0 comments
Closed

[PORT] Update Facebook, Slack, Webex adapters #660

tomlm opened this issue Jul 1, 2020 · 0 comments

Comments

@tomlm
Copy link
Contributor

tomlm commented Jul 1, 2020

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#4214

Update adapter Facebook, Slack, Webex adapters to follow the same pattern as Twilio

  • constructor accepts client and adapter options
  • separate options classes for client and adapter
  • remove generic exceptions
  • also removed redundant 'not implemented' code in Slack adapter and altered calling methods appropriately (made them synchronous)

Changed projects

  • Adapters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants