Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bf-connector] Cleanup Errors in authentication code #1445

Closed
stevengum opened this issue Nov 25, 2019 · 4 comments · Fixed by #1985
Closed

[bf-connector] Cleanup Errors in authentication code #1445

stevengum opened this issue Nov 25, 2019 · 4 comments · Fixed by #1985
Assignees
@Zerryth
Labels
P2 Nice to have R9 Release 9 - May 15th, 2020
Milestone
R9

Comments

@stevengum
Copy link
Member

In botframework-connector/authentication we return normal JS errors with non-normalized error messages.

This has led to manual Error.message parsing in determining the correct HTTP Status code to send back to the caller of the bot.

See #1433 (comment).
@stevengum stevengum added P2 Nice to have DX R7 Release 7 - December 10th, 2019 labels Nov 25, 2019
@stevengum stevengum mentioned this issue Nov 25, 2019
Merged
@stevengum stevengum added R8 Release 8 - March 16th, 2020 and removed R7 Release 7 - December 10th, 2019 labels Dec 2, 2019
@stevengum
Copy link
Member Author

Moving to R8 as this is a P2.

@carlosscastro carlosscastro self-assigned this Feb 10, 2020
@cleemullins cleemullins assigned Zerryth and unassigned carlosscastro Feb 25, 2020
@cleemullins
Copy link
Contributor

@Zerryth, pushing this to your backlog. We've been punting this for a while, and I would love to see it make it's way into R8. Given your current queue, I believe this is something we can do.

@Zerryth
Copy link
Contributor

Zerryth commented Feb 25, 2020

Sounds good!

@johnataylor
Copy link
Member

moving to R9

@johnataylor johnataylor added R9 Release 9 - May 15th, 2020 and removed R8 Release 8 - March 16th, 2020 labels Mar 3, 2020
@Zerryth Zerryth mentioned this issue Mar 13, 2020
Closed
@Zerryth Zerryth mentioned this issue Apr 2, 2020
Merged
@munozemilio munozemilio added this to the R9 milestone Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zerryth Zerryth

Labels
P2 Nice to have R9 Release 9 - May 15th, 2020
Projects
None yet
Milestone
R9
Development

Successfully merging a pull request may close this issue.

Move Error logic out of botbuilder into authentication layer microsoft/botbuilder-js
6 participants
@cleemullins @johnataylor @stevengum @carlosscastro @Zerryth @munozemilio