Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Skills] BotFrameworkHttpClient.postActivity should not error out on non-2xx status codes (language parity) #1514

Closed
stevengum opened this issue Dec 18, 2019 · 1 comment · Fixed by #1755
Closed

[Skills] BotFrameworkHttpClient.postActivity should not error out on non-2xx status codes (language parity) #1514

stevengum opened this issue Dec 18, 2019 · 1 comment · Fixed by #1755
Assignees
@johnataylor
Labels
P1 Painful if we don't fix, won't block releasing R8 Release 8 - March 16th, 2020
Milestone
R8

Comments

@stevengum
Copy link
Member

Versions

SDK: 4.7.0

Describe the bug

BotFrameworkHttpClient should not throw error inside of axios and instead return the response and status code to the caller of BotFrameworkHttpClient.postActivity()

Expected behavior

All status codes should be returned be surfaced to the bot and axios should not throw the error.

axios#41

@gabog, @johnataylor, @axelsrz:
We could also change the C# implementation to blow up instead of accepting statusCodes not between 200-299.

[bug]
@stevengum stevengum added R8 Release 8 - March 16th, 2020 Skills labels Dec 18, 2019
@stevengum stevengum changed the title [Skills] [Skills] BotFrameworkKHttpClient.postActivity should not error out on non-2xx status codes Dec 18, 2019
@gabog
Copy link
Contributor

gabog commented Dec 20, 2019

Changing the behavior either way would be a breaking change, we may just need to use try/catch in JS and python and inspect error code in C#

@clearab clearab added P2 Nice to have P1 Painful if we don't fix, won't block releasing and removed R8 Release 8 - March 16th, 2020 P2 Nice to have labels Feb 3, 2020
@clearab clearab changed the title [Skills] BotFrameworkKHttpClient.postActivity should not error out on non-2xx status codes [Skills] BotFrameworkKHttpClient.postActivity should not error out on non-2xx status codes (language parity) Feb 6, 2020
@clearab clearab added the R8 Release 8 - March 16th, 2020 label Feb 6, 2020
@carlosscastro carlosscastro self-assigned this Feb 10, 2020
@johnataylor johnataylor mentioned this issue Feb 20, 2020
Merged
@stevengum stevengum changed the title [Skills] BotFrameworkKHttpClient.postActivity should not error out on non-2xx status codes (language parity) [Skills] BotFrameworkHttpClient.postActivity should not error out on non-2xx status codes (language parity) Feb 28, 2020
@munozemilio munozemilio added this to the R8 milestone Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnataylor johnataylor

Labels
P1 Painful if we don't fix, won't block releasing R8 Release 8 - March 16th, 2020
Projects
None yet
Milestone
R8
Development

Successfully merging a pull request may close this issue.

return http state microsoft/botbuilder-js
6 participants
@clearab @johnataylor @gabog @stevengum @carlosscastro @munozemilio