Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BotFramework-Expressions] @types/lru-cache should be added in dependencies #1553

Closed
Batta32 opened this issue Jan 7, 2020 · 0 comments · Fixed by #1576
Closed

[BotFramework-Expressions] @types/lru-cache should be added in dependencies #1553

Batta32 opened this issue Jan 7, 2020 · 0 comments · Fixed by #1576
Assignees
Labels
bug Indicates an unexpected problem or an unintended behavior. R8 Release 8 - March 16th, 2020
Milestone

Comments

@Batta32
Copy link

Batta32 commented Jan 7, 2020

Versions

What package version of the SDK are you using.

What nodejs version are you using
10.8.0

What browser version are you using
-

What os are you using
Windows 10

Describe the bug

Give a clear and concise description of what the bug is.
The @types/lru-cache is missing in botframework-expressions as dependency in the package.json.

To Reproduce

Steps to reproduce the behavior:

  1. Add botbuilder-lg dependency version 4.7.0-preview (latest in npmjs) in the package.json
  2. Install the dependencies with npm install
  3. Compilate the solution with npm run build
  4. See the that @types/lru-cache dependency is missing in botframework-expressions

Expected behavior

Give a clear and concise description of what you expected to happen.
The compilation of the solution using botbuilder-lg@4.7.0-preview should be successful.
This should be fixed if @types/lru-cache is added in dependencies instead of devDependencies from the package.json of botframework-expressions library

Screenshots

If applicable, add screenshots to help explain your problem.
Error of a missing @types/lru-cache dependency
image

@types/lru-cache is used as devDependencies in botframework-expressions library
image

Additional context

Add any other context about the problem here.
-

[bug]

@vishwacsena vishwacsena added adaptive R8 Release 8 - March 16th, 2020 labels Jan 13, 2020
@munozemilio munozemilio added this to the R8 milestone Jul 1, 2020
@github-actions github-actions bot added bug Indicates an unexpected problem or an unintended behavior. image labels Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior. R8 Release 8 - March 16th, 2020
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants