Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Streaming] bf-streaming 4.7.0 requires TS projects to use "dom" lib in tsconfig.json #1565

Closed
stevengum opened this issue Jan 10, 2020 · 0 comments · Fixed by #1579
Closed
Assignees
Labels
P0 Must Fix. Release-blocker

Comments

@stevengum
Copy link
Member

stevengum commented Jan 10, 2020

Versions

What package version of the SDK are you using. 4.7.0

Describe the bug

BrowserWebSocket includes a dependency on a Browser type (WebSocket) which is satisfied through our package including "dom" in our tsconfig.json for bf-streaming.

export class BrowserWebSocket implements ISocket {
private webSocket: WebSocket;

Projects that use botbuilder and do not have "dom" in the libs of their tsconfig.json will be unable to build due to the missing type.

The immediate workaround is for projects with a dependency on botframework-streaming or botbuilder to add "dom" to the project's tsconfig.json, but we should remove this from our package and replace any "dom"-specific types with interfaces.

Expected behavior

Ability to build TS libraries that have a dependency on botbuilder without changing their tsconfig.json

Additional context

First reported via howdyai/botkit#1894

[bug]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Must Fix. Release-blocker
Projects
None yet
1 participant