Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] [Expression] Expanding max/min built-in functions can take list params #1671

Closed
tomlm opened this issue Feb 6, 2020 · 1 comment · Fixed by #1674
Closed

[PORT] [Expression] Expanding max/min built-in functions can take list params #1671

tomlm opened this issue Feb 6, 2020 · 1 comment · Fixed by #1674
Assignees

Comments

@tomlm
Copy link
Contributor

tomlm commented Feb 6, 2020

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#3345

closes: #3343

Now max/ min functions can also take a list of numeric values as a parameter.
For example:
max(createArray(1, 2, 3))
min(createArray(1, 2, 3))

Also they can take a mixing of numeric lists and numeric values.
max(createArray(1, 2, 3), 5)
min(createArray(1, 2, 3), 5)

Changed projects

  • Microsoft.Bot.Expressions
  • Microsoft.Bot.Expressions.Tests
@Stevenic
Copy link
Contributor

Needs port

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants