Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PORT] Added interruptions support to SkillDialog #1860

Closed
tomlm opened this issue Mar 5, 2020 · 0 comments · Fixed by #1867
Closed

[PORT] Added interruptions support to SkillDialog #1860

tomlm opened this issue Mar 5, 2020 · 0 comments · Fixed by #1867
Assignees
@stevengum
Labels
P1 Painful if we don't fix, won't block releasing R8 Release 8 - March 16th, 2020
Milestone
R8

Comments

@tomlm
Copy link
Contributor

tomlm commented Mar 5, 2020

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#3507

Fixes #3506

Added RepromptDialogAsync and ResumeDialogAsync to SkillDialog.
Moved skill request handling logic into Dialog.RunAsync
Updated sample DialogToDialog sample to handle interruptions

Changed projects

  • Microsoft.Bot.Builder.Dialogs

[Skills]
@github-actions github-actions bot added the Skills label Mar 5, 2020
@gabog gabog added P1 Painful if we don't fix, won't block releasing R8 Release 8 - March 16th, 2020 labels Mar 5, 2020
@stevengum stevengum self-assigned this Mar 6, 2020
This was referenced Mar 6, 2020
Merged
Merged
@munozemilio munozemilio added this to the R8 milestone Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevengum stevengum

Labels
P1 Painful if we don't fix, won't block releasing R8 Release 8 - March 16th, 2020
Projects
None yet
Milestone
R8
Development

Successfully merging a pull request may close this issue.

Add interruption support to SkillDialog and runDialog helper method microsoft/botbuilder-js
4 participants
@gabog @stevengum @tomlm @munozemilio