Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EoC should only be handled when coming from parent in runDialog() #1895

Closed
stevengum opened this issue Mar 12, 2020 · 1 comment · Fixed by #1898
Closed

EoC should only be handled when coming from parent in runDialog() #1895

stevengum opened this issue Mar 12, 2020 · 1 comment · Fixed by #1898
Assignees
@stevengum
Labels
P0 Must Fix. Release-blocker R8 Release 8 - March 16th, 2020
Milestone
R8

Comments

@stevengum
Copy link
Member

RunAsync currently calls cancelAllDialogs when a parent sends an EoC activity and when the skills returns EoC.

It should only call cancelAllDialogs when the EoC comes from a parent, otherwise it discards the return value from the skill.

@gabog's comment in microsoft/botbuilder-dotnet#3541
@stevengum stevengum added P0 Must Fix. Release-blocker R8 Release 8 - March 16th, 2020 Skills labels Mar 12, 2020
@stevengum stevengum self-assigned this Mar 12, 2020
@stevengum stevengum changed the title EoC should only be handled when coming from parent in runDialog EoC should only be handled when coming from parent in runDialog() Mar 12, 2020
@stevengum stevengum mentioned this issue Mar 12, 2020
Merged
@stevengum
Copy link
Member Author

Closing via #1896

@stevengum stevengum mentioned this issue Mar 12, 2020
Merged
@munozemilio munozemilio added this to the R8 milestone Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevengum stevengum

Labels
P0 Must Fix. Release-blocker R8 Release 8 - March 16th, 2020
Projects
None yet
Milestone
R8
Development

Successfully merging a pull request may close this issue.

[master, cherry-pick] fix runDialog helper, fix callerId microsoft/botbuilder-js
2 participants
@stevengum @munozemilio