Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] Make the CRUD of the template consistent #1954

Closed
tomlm opened this issue Mar 27, 2020 · 0 comments · Fixed by #1952
Closed

[PORT] Make the CRUD of the template consistent #1954

tomlm opened this issue Mar 27, 2020 · 0 comments · Fixed by #1952

Comments

@tomlm
Copy link
Contributor

tomlm commented Mar 27, 2020

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#3622

Originally, we treat LG file as the combination of templates and use empty string as the separator.
From now on separator "\r\n" would be used.

So, if we update a template with the body "- A", we would always get the body "- A" but not "-A\r\n" in any case. This idempotent relationship will greatly increase robustness and consistency

Changed projects

  • Microsoft.Bot.Builder.LanguageGeneration
  • Microsoft.Bot.Builder.LanguageGeneration.Tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant