Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade antlr4ts library #3209

Closed
Danieladu opened this issue Jan 21, 2021 · 0 comments
Closed

Upgrade antlr4ts library #3209

Danieladu opened this issue Jan 21, 2021 · 0 comments
Assignees
@joshgummersall @Danieladu
Labels
Area: Adaptive expression The issue is related to Adaptive expressions Area: LG Language generation issues backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. P1 Painful if we don't fix, won't block releasing
Milestone
R15

Comments

@Danieladu
Copy link
Contributor

Danieladu commented Jan 21, 2021 •
edited
Loading

Description

adaptive-expressions and LG library depends on antlr4ts to parse expression and lg file.

Several days ago, antlr4ts release its new version contains such main updates:

  • Upgrade typescript from 3.5.3 to 4.x
  • Update antlr version from 4.7 to 4.9 directly.

Expected behavior

Upgrade antlr version from 0.5.0-alpha.3 to 0.5.0-alpha.4 which would benefits from the more modern ECMAScript features in typescript 4.x

References

Typescript upgrade issue: #1441
Typescript upgrade pr for other projects: #2990
Release log
@Danieladu Danieladu added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. Area: Adaptive expression The issue is related to Adaptive expressions Area: LG Language generation issues and removed bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Jan 21, 2021
@Danieladu Danieladu self-assigned this Jan 21, 2021
@Danieladu Danieladu changed the title Upgrade Antlr/TypeScript version for adaptive-expression and lg library Upgrade antlr4ts library Jan 21, 2021
@Danieladu Danieladu mentioned this issue Jan 22, 2021
Closed
@joshgummersall joshgummersall mentioned this issue Feb 3, 2021
Closed
@Danieladu Danieladu added the backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. label Mar 31, 2021
@joshgummersall joshgummersall self-assigned this Jun 5, 2021
@mrivera-ms mrivera-ms added this to the R14 milestone Jun 5, 2021
@mrivera-ms mrivera-ms added the P1 Painful if we don't fix, won't block releasing label Jun 5, 2021
@joshgummersall joshgummersall modified the milestones: R14, R15 Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshgummersall joshgummersall

@Danieladu Danieladu

Labels
Area: Adaptive expression The issue is related to Adaptive expressions Area: LG Language generation issues backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. P1 Painful if we don't fix, won't block releasing
Projects
None yet
Milestone
R15
Development

Successfully merging a pull request may close this issue.

Upgrade Antlr microsoft/botbuilder-js
3 participants
@joshgummersall @Danieladu @mrivera-ms