Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: Support null for buildin function empty (#5338) #3483

Closed
github-actions bot opened this issue Mar 30, 2021 · 2 comments · Fixed by #3484
Closed

port: Support null for buildin function empty (#5338) #3483

github-actions bot opened this issue Mar 30, 2021 · 2 comments · Fixed by #3484
Assignees
@Danieladu
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.

Comments

@github-actions
Copy link

The changes in Support null for buildin function empty (#5338) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #5337

Description

The doc of empty shows that if the input is null, true would be given.

Example:

empty(null)   -> true

Please review and, if necessary, port the changes.
@github-actions github-actions bot added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Mar 30, 2021
@joshgummersall
Copy link
Contributor

@Danieladu I vaguely recall that you may have already fixed this in JS? If not, can you handle porting the change?

@Danieladu
Copy link
Contributor

Nope. I have dropped this change in the previous PR. I would take this one.

@Danieladu Danieladu mentioned this issue Mar 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Danieladu Danieladu

Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

port: Support null for built-in function empty microsoft/botbuilder-js
2 participants
@joshgummersall @Danieladu