Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: Mark GetTeamMembersAsync as Obsolete and provide guidance to now use … (#6244) #4143

Closed
github-actions bot opened this issue Mar 4, 2022 · 1 comment
Closed

port: Mark GetTeamMembersAsync as Obsolete and provide guidance to now use … (#6244) #4143

github-actions bot opened this issue Mar 4, 2022 · 1 comment
Assignees
@JuanAr
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. P1 Painful if we don't fix, won't block releasing parity The issue describes a gap in parity between two or more platforms. Size: S The issue is simple and well understood, it will take a day or less to complete
Milestone
R16

Comments

@github-actions
Copy link

github-actions bot commented Mar 4, 2022

The changes in Mark GetTeamMembersAsync as Obsolete and provide guidance to now use … (#6244) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

…GetPagedTeamMembersAsync.

Fixes #6243

Description

Marked GetTeamMembersAsync as Obsolete as they rely on APIs that are being deprecated by Teams.

Specific Changes

Marked APIs as Obsolete and provided guidance to use alternative APIs.

Testing

Unit test were executed though nothing was changed that should modify behavior of the SDK.

Please review and, if necessary, port the changes.
@github-actions github-actions bot added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Mar 4, 2022
@gabog gabog added this to the R16 milestone Mar 4, 2022
@gabog gabog added P1 Painful if we don't fix, won't block releasing Size: S The issue is simple and well understood, it will take a day or less to complete and removed needs-triage The issue has just been created and it has not been reviewed by the team. labels Mar 4, 2022
@LeeParrishMSFT
Copy link
Contributor

@gabog I already completed this with this PR: #4141 and I had created this issue to track it: #4140 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuanAr JuanAr

Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. P1 Painful if we don't fix, won't block releasing parity The issue describes a gap in parity between two or more platforms. Size: S The issue is simple and well understood, it will take a day or less to complete
Projects
None yet
Milestone
R16
Development

No branches or pull requests
3 participants
@JuanAr @gabog @LeeParrishMSFT