Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: [#5800] AdaptiveExpression Bool function is not very useful because it doesn't convert anything but ints (#6431) #4309

Closed
github-actions bot opened this issue Aug 9, 2022 · 0 comments · Fixed by #4320
Closed

port: [#5800] AdaptiveExpression Bool function is not very useful because it doesn't convert anything but ints (#6431) #4309

github-actions bot opened this issue Aug 9, 2022 · 0 comments · Fixed by #4320
Assignees
@JuanAr
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.

Comments

@github-actions
Copy link

github-actions bot commented Aug 9, 2022

The changes in [#5800] AdaptiveExpression Bool function is not very useful because it doesn't convert anything but ints (#6431) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #5800

Description

This PR updated the Bool built-in function to evaluate 'true' and 'false' strings as booleans using the Convert.ToBoolean() method.

Specific Changes

  • Updated Function method of AdaptiveExpressions/BuiltinFunctions/Bool to evaluate strings using Convert.ToBoolean().
  • Updated AdaptiveExpressions.Tests/ExpressionParserTests to evaluate bool('false') as false and added a new test case for bool('true')

Testing

This image shows the unit tests passing.
image

Please review and, if necessary, port the changes.
@github-actions github-actions bot added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Aug 9, 2022
@sw-joelmut sw-joelmut mentioned this issue Sep 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuanAr JuanAr

Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
No milestone
1 participant
@JuanAr