Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit error logging inside jwtTokenExtractor in botframework-connector #4324

Closed
itstaby opened this issue Sep 19, 2022 · 1 comment · Fixed by #4333
Closed

Explicit error logging inside jwtTokenExtractor in botframework-connector #4324

itstaby opened this issue Sep 19, 2022 · 1 comment · Fixed by #4333
Assignees
@JuanAr
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository. needs-triage The issue has just been created and it has not been reviewed by the team.

Comments

@itstaby
Copy link

itstaby commented Sep 19, 2022

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.

Versions

What package version of the SDK are you using. 4.16 (botframework-connector)
What nodejs version are you using 14.17.1
What browser version are you using N/A
What os are you using MacOS Monterey 12.5.1

Describe the bug

There is an explicit console.error statement here in jwtTokenExtractor. This error is then thrown and handled by us, but the log entry is still made which results in noise in our logs as well as the possibility for triggering associated alarms.

Why is this needed if the error is being thrown and will be logged if not handled by the caller?

Expected behavior

Error is thrown, handling/logging is left to the caller.
@itstaby itstaby added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Sep 19, 2022
@anishprasad01 anishprasad01 added customer-reported Issue is created by anyone that is not a collaborator in the repository. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. labels Sep 19, 2022
@munozemilio munozemilio self-assigned this Sep 20, 2022
@tracyboehrer tracyboehrer assigned JuanAr and unassigned munozemilio Oct 4, 2022
@johnataylor
Copy link
Member

@itstaby thanks for opening the issue, you make a good point, I think we can fix this

@johnataylor johnataylor added the customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. label Oct 7, 2022
@ceciliaavila ceciliaavila mentioned this issue Oct 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuanAr JuanAr

Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository. needs-triage The issue has just been created and it has not been reviewed by the team.
Projects
None yet
Milestone
No milestone
5 participants
@JuanAr @johnataylor @itstaby @anishprasad01 @munozemilio