Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HashSet instead of string array for endorsement #4454

Closed
jineshjin opened this issue Apr 21, 2023 · 0 comments · Fixed by #4526
Closed

Use HashSet instead of string array for endorsement #4454

jineshjin opened this issue Apr 21, 2023 · 0 comments · Fixed by #4526
Labels
feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team.

Comments

@jineshjin
Copy link

jineshjin commented Apr 21, 2023

Use this query to search for the most popular feature requests.

Is your feature request related to a problem? Please describe.
Yes as part of complexity

Describe the solution you'd like
we would like to have O(1) complexity instead of O(N)

Describe alternatives you've considered
Have to rely on O(N)

Additional context
As mentioned here: https://github.com/microsoft/botbuilder-js/blob/main/libraries/botframework-connector/src/auth/endorsementsValidator.ts#L50 when are we planning to use HashSet for endorsement.

@jineshjin jineshjin added feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team. labels Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team.
Projects
None yet
1 participant