Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files whose names include a plus sign are not referenced in TeamsActivityHandler.onMessage attachments #4750

Open
vojtechcahlik-ext44653 opened this issue Sep 17, 2024 · 0 comments
Assignees
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@vojtechcahlik-ext44653
Copy link

Versions

botbuilder version: 4.22.2
Node version: 18.14.0

Expected behavior

When a user uploads a file and sends it as part of a message, the TeamsActivityHandler.onMessage method should be called and the file should be correctly referenced in context.activity.attachments.

Describe the bug

When the uploaded file contains a plus symbol (e.g. for a file named "document+comments.pdf"), the TeamsActivityHandler.onMessage method is called without referencing the file in context.activity.attachments. Therefore, the information about a file being included in the message is lost.

Curiously, with the application I'm working on, the file (e.g. "document+comments.pdf") gets uploaded to SharePoint. So it seems that the information about the file is lost somewhere further along the way.

To Reproduce

  1. On your computer, create a local file with a plus symbol in its name (e.g. "document+comments.pdf")
  2. In a Teams bot chat, write a message (any text) without sending it yet
  3. Attach the file to the message (choose upload from local device)
  4. Send the message (with the attached file)
  5. Information about the uploaded file will be missing from context.activity.attachments in TeamsActivityHandler.onMessage
@vojtechcahlik-ext44653 vojtechcahlik-ext44653 added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Sep 17, 2024
@tracyboehrer tracyboehrer removed the needs-triage The issue has just been created and it has not been reviewed by the team. label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Development

No branches or pull requests

3 participants