Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot builder dependencies to other builder packages should use ~ versioning instead of ^ #652

Closed
msft-shahins opened this issue Nov 20, 2018 · 4 comments
Assignees

Comments

@msft-shahins
Copy link

Versions

All 4.x.x releases suffer from this issue

Describe the bug

Bot builder dependencies in packages.json are currently ^4.0.0 when importing other bot builder package dependencies, e.g. botbuilder-core. This causes having a hard dependency on exact versions of botbuilder, e.g. 4.0.8, to bring in latest version of botbuilder-core, e.g. 4.1.5, that might have some breaking changes.

To Reproduce

Have a dependency on botbuilder: "4.0.8" in your node project and see that botbuilder-core version will be "4.1.5" installed as dependency.

@johnataylor
Copy link
Member

Given we are currently releasing the packages together we could happily set the dependency as exact.

@stevengum
Copy link
Member

Jumping on @johnataylor's point, we also only test the latest bits together, we do not test cases between 4.0.8 and 4.1.5, let alone testing 4.1.4 with a dependency on 4.1.5.

@benbrown as someone more well versed in the ecosystem and what others are doing with their packages, can you chime in with your opinion?

FWIW, I support pinning to specific versions over sticking to patch releases (~).

@benbrown
Copy link
Contributor

I'm not sure there is a strong established opinion about ^ vs ~ within intertwined packages like ours, but @johnataylor's reasoning rings true to me.

The only concern I have with this is that it requires us to more frequently update the package files - at every minor release instead of major. That's fine, but we should consider putting together a release checklist to keep track of this process.

@benbrown
Copy link
Contributor

benbrown commented Nov 21, 2018

Ready for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants