Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] disable unused codeSignValidationInjection task in main CI #1152

Closed
tomlm opened this issue Jun 17, 2020 · 1 comment
Closed

[PORT] disable unused codeSignValidationInjection task in main CI #1152

tomlm opened this issue Jun 17, 2020 · 1 comment

Comments

@tomlm
Copy link
Contributor

tomlm commented Jun 17, 2020

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#4056

Partially addresses: #4055

Build 137843 for these changes has a total duration of 21min and 16s:

image

The last successful build (137707) took 27min 12s to complete:

image


This PR speeds up the build by disabling the auto-injected "Run Codesign Validation" task, which was running at the end of our stages. This task automaically fetches an internal tool for the codesign validation step and applicable .NET Core SDKs before eventually skipping the workflow, a process that takes around one minute.

Searching for the variable name, there were other Microsoft projects that also disabled this task as it was N/A. (microsoft/terminal#4387 and microsoft/react-native-windows#3923)

@stevengum
Copy link
Member

N/A this task is already skipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants