New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PORT] Update Facebook, Slack, Webex adapters #1204

Closed

tomlm opened this issue Jul 1, 2020 · 0 comments

Contributor

tomlm commented Jul 1, 2020

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#4214

Update adapter Facebook, Slack, Webex adapters to follow the same pattern as Twilio

constructor accepts client and adapter options
separate options classes for client and adapter
remove generic exceptions
also removed redundant 'not implemented' code in Slack adapter and altered calling methods appropriately (made them synchronous)

Changed projects

Adapters

tracyboehrer closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment