Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOS line-endings in @microsoft/botframework-cli/bin/run when installed with yarn #711

Open
ChrisRenfrow opened this issue Apr 15, 2020 · 7 comments
Assignees
Labels
Area: Schema The issue is related to schemas (bot schemas, skill manifest, etc.) backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository. ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. feature-request A request for new functionality or an enhancement to an existing one.

Comments

@ChrisRenfrow
Copy link

ChrisRenfrow commented Apr 15, 2020

Versions

What CLI version are you using.
@microsoft/botframework-cli/4.8.0 linux-x64 node-v13.12.0
What Nodejs version are you using
v13.12.0
What command-line interpreters are you using
bash
What OS are you using
Manjaro Linux 4.19.114-1

Describe the bug

Installing bf in a *nix environment using yarn@v1.22.4 results in the following error
/usr/bin/env: ‘node\r’: No such file or directory

To Reproduce

Steps to reproduce the behavior:

  1. Install on Linux 4.19 using yarn global add @microsoft/botframework-cli
  2. Run bf

Expected behavior

I expected it to run without the error detailed above

Workaround

Install using npm@v6.14.4 instead, otherwise if installing with yarn@v1.22.4 try the following:

  1. Install dos2unix
  2. Locate @microsoft/botframework-cli/bin/run
    • This will vary depending on how bf was installed
    • Mine was located at ~/.config/yarn/global/node_modules/@microsoft/botframework-cli/bin/run
  3. Use dos2unix on run

Note: dos2unix will not work on symbolically linked files so be sure to locate the actual file

[bug]

@axelsrz
Copy link
Member

axelsrz commented Apr 16, 2020

Hey @munozemilio could you take a look at this?

@munozemilio
Copy link
Member

Hello @ChrisRenfrow. I just installed and ran the cli in a clean vm and the command worked just fine.
Screen Shot 2020-04-16 at 10 32 39 PM

@munozemilio munozemilio added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository. labels Apr 17, 2020
@ChrisRenfrow ChrisRenfrow changed the title DOS line-endings in @microsoft/botframework-cli/bin/run DOS line-endings in @microsoft/botframework-cli/bin/run when installed with yarn Apr 17, 2020
@ChrisRenfrow
Copy link
Author

@munozemilio Upon closer inspection it looks like it has something to do with installing using yarn rather than npm. I've included more details above.

@munozemilio
Copy link
Member

Got it. I will flag this as an enhancement. We have no documentation around yarn so that be something we will have to add/test and flag as supported. Thanks for reporting this @ChrisRenfrow

@munozemilio munozemilio added R10 Release 10 - August 17th, 2020 enhancement labels Apr 17, 2020
@munozemilio munozemilio removed the R10 Release 10 - August 17th, 2020 label Jun 23, 2020
@srinaath srinaath assigned scheyal and unassigned munozemilio Jun 25, 2020
@scheyal
Copy link
Contributor

scheyal commented Jun 25, 2020

Investigation: Issue is indeed 0a0d in first line
#!/usr/bin/env node

@cleemullins cleemullins added the R10 Release 10 - August 17th, 2020 label Jul 6, 2020
@cleemullins
Copy link
Contributor

@scheyal Can you provide an update? This seems straightforward to fix.

@scheyal scheyal assigned scheyal and munozemilio and unassigned scheyal Jul 13, 2020
@scheyal
Copy link
Contributor

scheyal commented Jul 13, 2020

@scheyal scheyal removed their assignment Jul 21, 2020
@scheyal scheyal added R11 and removed R10 Release 10 - August 17th, 2020 labels Jul 21, 2020
@gabog gabog added this to the R11 milestone Sep 10, 2020
@gabog gabog added feature-request A request for new functionality or an enhancement to an existing one. and removed R11 labels Sep 10, 2020
@tsuwandy tsuwandy added Area: Schema The issue is related to schemas (bot schemas, skill manifest, etc.) R11 labels Sep 14, 2020
@munozemilio munozemilio removed the R11 label Oct 14, 2020
@munozemilio munozemilio removed this from the R11 milestone Oct 14, 2020
@munozemilio munozemilio added the backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. label Oct 19, 2020
@chrimc62 chrimc62 added the ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. label Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Schema The issue is related to schemas (bot schemas, skill manifest, etc.) backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository. ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. feature-request A request for new functionality or an enhancement to an existing one.
Projects
None yet
Development

No branches or pull requests

8 participants