Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCR: Add State to the Semantic Action definition in Schema #5403

Closed
3 tasks done
cleemullins opened this issue May 24, 2019 · 4 comments
Closed
3 tasks done

DCR: Add State to the Semantic Action definition in Schema #5403

cleemullins opened this issue May 24, 2019 · 4 comments
Assignees
Labels
P1 Painful if we don't fix, won't block releasing

Comments

@cleemullins
Copy link
Contributor

cleemullins commented May 24, 2019

We've been asked to add the 'state' to the SemanticAction definition in Microsoft.Bot.Schema (SDK). The spec has this defined.

This work needs to be done in:

@gabog
Copy link
Contributor

gabog commented Jun 12, 2019

Hi @cleemullins, I am looking at https://github.com/microsoft/botframework-sdk/blob/master/specs/botframework-activity/botframework-activity.md#semantic-action-type and can't find 'state' mentioned there, am I looking at the wrong place?
If I got this wrong and state still needs to be added, do you know what type it should be?

@EricDahlvang
Copy link
Member

@gabog SemanticActionStates is in the latest connector swagger file: https://github.com/microsoft/botframework-sdk/blob/master/specs/botframework-protocol/botframework-channel.json#L2145

Here is a PR to add it to dotnet: microsoft/botbuilder-dotnet#2027

@gabog
Copy link
Contributor

gabog commented Jun 12, 2019

Ah, cool, I will transfer the dotnet PR to you so you can close it once your PR goes in.

@EricDahlvang
Copy link
Member

Closing this ... all three language repos mentioned above are finished and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Painful if we don't fix, won't block releasing
Projects
None yet
Development

No branches or pull requests

3 participants