New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is copy constructor needed indeed? #175

Open

jdneo opened this issue Jul 22, 2024 · 1 comment

Labels

Member

jdneo commented Jul 22, 2024

See:

build-server-for-gradle/server/src/main/java/com/microsoft/java/bs/core/internal/gradle/GradleApiConnector.java

Lines 103 to 105 in 6aa16d8

    
           // since the model returned from Gradle TAPI is a wrapped object, here we re-construct it 
        
           // via a copy constructor and return as a POJO. 
        
           return new DefaultGradleSourceSets(buildExecutor.run());

jdneo mentioned this issue

Parallelize source set retrieval. #168

Merged

jdneo mentioned this issue

Handle java source/target defined at extension level #188

Merged

Member Author

jdneo commented Sep 2, 2024 •

edited

Loading

See: #188 (comment)

Looks like, if we want to get rid of the copy constructor, we need to add an api for the model, somthing like getGradleSourceSetInstance(). Similar to what we did in the LanguageExtension: https://github.com/microsoft/build-server-for-gradle/blob/develop/model/src/main/java/com/microsoft/java/bs/gradle/model/LanguageExtension.java#L70

jdneo added the help wanted label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment