Remove Serialize/Deserialize functions never used in StandardCalculatorViewModel, UnitConverter and UnitConverterViewModel #370
Labels
codebase quality
Issues that are not bugs, but still might be worth improving (eg, code hygiene or maintainability)
fixed
Pri: 3
Describe the change requested
StandardCalculatorViewModel
as well asUnitConverterViewModel
andUnitConverter
contain custom binary serializers and deserializers never used by the application. I suspect they were used a long time ago when the app lifecycle model was more restricted (Windows Phone 8/8.1?).These unused functions make it harder to add features or refactor these 3 classes, especially due to the format used (custom binary serialization).
A big part of the information saved by
UnitConverter
for example is not relevant or is redundant:CurrentCategory
is already saved inLocalSettings
byMainPage
FromType
andToType
are already saved by the functionUnitConverter::SaveUserPreferences
(in file) as well as byUnitConverterViewModel::SaveUserPreferences()
(in LocalSettings)ratioMapTokens
is based on static data (for unit conversion) or data already backed up byCurrencyDataLoader
Prerequisite
Be sure Microsoft doesn't use these functions in tools or code not in the git repository (integration tests, tools used by QA, etc..)
Functions no longer used we can remove
The text was updated successfully, but these errors were encountered: