Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: There is seemingly no reason for the EmissionData.Location to be nullable #234

Open
1 task done
Lybecker opened this issue Jan 3, 2023 · 0 comments
Open
1 task done

[Bug]: There is seemingly no reason for the EmissionData.Location to be nullable #234

Lybecker opened this issue Jan 3, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@Lybecker
Copy link
Member

Lybecker commented Jan 3, 2023

Contact Details

anlybeck@microsoft.com

What happened?

Looking thought the code, it seems there is a bug in the contract, as Location does not need to be nullable:

carbon-aware-sdk/src/GSF.CarbonAware/src/Models/EmissionsData.cs

Line 5 in 14ef3e7

public string? Location { get; init; }

client

CLI

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Lybecker Lybecker added the bug Something isn't working label Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Lybecker