New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpp/path-injection Overhaul #60

Open

bdrodes opened this issue Mar 28, 2024 · 0 comments

Assignees

Labels

question

bdrodes commented Mar 28, 2024

I received false positive reports on https://github.com/microsoft/codeql/blob/bbdf97e8f3acb64be15ca59a3ae3366cd6fc8cd5/cpp/ql/src/Security/CWE/CWE-022/TaintedPath.ql
(cpp/path-injection). The users were attempting to filter the paths by looking for ".." but the path still appears vulnerable. One example provided was something like this if (pathString.find("..") != std::string::npos). Generally, the query relies on hasUpperBoundCheck, but this may need to be updated to match similar queries in other languages.

bdrodes added the question label

bdrodes self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment