Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Replace cordova-plugin-file-transfer with standard-compliant implementation #485

Open
jacobg opened this issue Dec 20, 2018 · 8 comments
Open
Assignees

Comments

@jacobg
Copy link

jacobg commented Dec 20, 2018

cordova-plugin-file-transfer is deprecated and buggy (see #234). The plugin can be completely replaced with a standard-compliant implementation that works on Android >= 4.4 and iOS >= 10.

The Cordova team published a blog article last year explaining this transition:
https://cordova.apache.org/blog/2017/10/18/from-filetransfer-to-xhr2.html

Regarding the minimum required versions for the standard-compliant implementation, the latest version of Cordova Android platform already requires a minimum version of 4.4 (SDK 19).
Source: https://cordova.apache.org/docs/en/latest/guide/platforms/android/

And Apple has announced that they will soon require all app submissions to target a minimum version of iOS 12:

Starting March 2019, all iOS apps submitted to the App Store will need to be built with the iOS 12.1 SDK or later.
Source: https://developer.apple.com/ios/submit/

So it seems that cordova-plugin-code-push should transition off of cordova-plugin-file-transfer to a more modern and stable approach.

@yuri-kulikov
Copy link
Contributor

Hi @jacobg,
Thanks for the feedback!

Yes, it sounds pretty reasonable, we will add this item to our backlog and look at it in more detail. I can't say for sure when we solve this issue but we'll keep you posted.

@bytenik
Copy link
Contributor

bytenik commented Mar 21, 2019

@yuri-kulikov Are you open to a pull request to resolve this?

@yuri-kulikov
Copy link
Contributor

Hey @jacobg

Of course, we'll review it when we have time. We really appreciate it! 👍

@bytenik
Copy link
Contributor

bytenik commented Mar 22, 2019

@yuri-kulikov Okay, a member of my team created this PR for you: #513

This should resolve this issue.

@bytenik
Copy link
Contributor

bytenik commented Mar 29, 2019

@yuri-kulikov It appears your server is not set up correctly for CORS. Since there's no CORS header, XHR requests for the update package fail. Who can I escalate this to in order to get that addressed?

@GuilleBarrena
Copy link

How is this going? I have installed the latest version of the plugin "1.12.0" and it still uses FileTransfer plugin which is deprecated.

@EvanWieland
Copy link

Also having issues with this.

@ermik
Copy link
Contributor

ermik commented Nov 23, 2019

#513 needs help from people familiar with the code base.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants