Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json.hpp compiler errors when compiling on MSVC #833

Closed
SahilAshar opened this issue Apr 21, 2021 · 1 comment · Fixed by #839
Closed

json.hpp compiler errors when compiling on MSVC #833

SahilAshar opened this issue Apr 21, 2021 · 1 comment · Fixed by #839
Assignees
@maxgolov
Labels
bug Something isn't working

Comments

@SahilAshar
Copy link
Contributor

When compiling win32-lib on MSVC, \lib\include\mat\json.hpp throws warning C28020: The expression '0<=_Param_(1)&&_Param_(1)<=400-1' is not true at this call.: Lines: 14534, 14554, which is treated as an error.

This is a known issue and was fixed in Release 3.8.0 of the JSON library.
@SahilAshar SahilAshar added the bug Something isn't working label Apr 21, 2021
@maxgolov
Copy link
Contributor

Please use pragma for now to disable the warning. We can consider upgrading dependency for the next release, assuming there is no push-back. It may require a few iterations for each product to register the usage of specific OSS library version.

@maxgolov maxgolov mentioned this issue Apr 23, 2021
Merged
@maxgolov maxgolov self-assigned this Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxgolov maxgolov

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update json.hpp to v3.9.1 microsoft/cpp_client_telemetry
2 participants
@SahilAshar @maxgolov