Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol extension points #435

Closed
EvilBeaver opened this issue Oct 4, 2023 · 3 comments
Closed

Protocol extension points #435

EvilBeaver opened this issue Oct 4, 2023 · 3 comments
Assignees
Labels
under-discussion Issue is under discussion for relevance, priority, approach

Comments

@EvilBeaver
Copy link
Contributor

Language server protocol has extension points where authors can append their own language features over default protocol. Can we have this in DAP?

For example, in IntelliJ IDEA there's breakpoints feature "Stop only after another breakpoint hits". I could implement specific UI as IDE extension which sets up this feature and use DAP extension to pass data from IDE to runtime.

@connor4312
Copy link
Member

For example, in IntelliJ IDEA there's breakpoints feature "Stop only after another breakpoint hits".

This is not something that needs to be expressed in DAP. In fact there is a PR for just that in VS Code that doesn't require any DAP extensions.

Currently I have little appetite for an arbitrary 'extension mechanism'. Of course, as it's JSON, clients and adapters are free to implement their own additional properties, and we did a little bit of that to make VS Code extension debugging work in the days before there were the necessary DAP semantics.

If there are specific things you see are missing in DAP, by all means please create issues! 🙂

@connor4312 connor4312 added the under-discussion Issue is under discussion for relevance, priority, approach label Oct 4, 2023
@connor4312 connor4312 self-assigned this Oct 4, 2023
@EvilBeaver
Copy link
Contributor Author

Thanks for the answer

@connor4312
Copy link
Member

Please feel free to comment/open a new issue if you want to discuss further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

2 participants