Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone repo #6

Open
dhruvchand opened this issue Apr 19, 2023 · 2 comments
Open

Clone repo #6

dhruvchand opened this issue Apr 19, 2023 · 2 comments
Labels

Comments

@dhruvchand
Copy link
Collaborator

dhruvchand commented Apr 19, 2023

Is your feature request related to a problem? Please describe.
I would like to clone a repo I have access to

Describe the solution you'd like
parameters to support:

  1. src repo url
  2. clone to directory
  3. params to pass to git clone

Support for repo sources:

  1. github
  2. ADO

pre-requisites:
If git and GCM (>= GCM 2.1..2,) are not installed, install them first. We should check if PATH already contains git and GCM. If yes, but older versions: overwrite with supported git and gcm version.

setupTasks:
  - task: clone-repository-on-login
    inputs:
      src: "repo-url"
      cloneTo: "./path/"
      additionalOptions: "--flag --key val"
@dhruvchand dhruvchand added the P2 label May 10, 2023
@jmatthiesen
Copy link
Member

A few design questions:

  • How will we ensure that Git & Git Credential Manager are on the box?
  • What min-versions of Git & GCM do we want to require? The latest release, GCM 2.1..2, specifically includes some new functionality that will improve Azure Repos OAuth connectivity (Use OAuth tokens on DevBox by default for Azure Repos git-ecosystem/git-credential-manager#1245)
  • I understand that this version of this task will run upon first user login so that we can prompt for OAuth - should we make that explicit in the name like "clone-repository-on-login"?

@dhruvchand
Copy link
Collaborator Author

Jordan and I discussed this... considering we're going to be in private preview, we can name the task clone-repository-on-login and be more explicit and set expectations that this would run after login, unlike all the other tasks that we provide. We could deprecate it later once we have a way to clone repositories at provision time using secrets. I updated to comment to reflec this, and GCM dependencies
cc @antonellaavogadro @DavidObando thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants