Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard][Feature request] Turning off extensions should make widget disappear (or something) and not be able to be added #1892

Closed
mathewleeza opened this issue May 18, 2023 · 3 comments
Assignees
Labels
Area-Extensibility Related to extensions Issue-Feature New feature or request Priority-1 Resolution-Duplicate This issue or pull request already exists

Comments

@mathewleeza
Copy link
Contributor

mathewleeza commented May 18, 2023

Dev Home version

No response

Windows build number

No response

Other software

No response

Steps to reproduce the bug

Description

  1. have widgets on dashboard
  2. turn off GitHub ext
  3. widgets remain on
  4. click "Add" and they still are able to be added

widgets shouldn't be present as Dev Home shouldn't 'see' the extension anymore

This is a complicated problem, and unlikely to make it for Build. We want users to know that we know that it's a problem, so we can create a public GitHub issue for it right when we release.

Can we have PM decide on functionality here? (And it's a big enough decision I think it should be documented.) The suggestion in this bug is not inherently correct (even if we decide it's the functionality we want). DevHome knows about these widgets because the extension registered the widgets with the widget platform. It has nothing to do with the extension's communication with the core app.

If you decide to do this, it severely limits third party widgets in the future. You'd be saying "to have a widget in DevHome, you have to write a DevHome extension". You couldn't write your own app and have DevHome display your widget. Obviously made up example, but if we weren't doing our own ADO widgets, ADO could never write a native client that included a widget used in DevHome. They'd HAVE to also write an extension.

Expected result

No response

Actual result

No response

Included System Information

No response

Included Extensions Information

No response

@mathewleeza mathewleeza added Issue-Bug Something isn't working or needs investigation Priority-1 labels May 18, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage New issue that the core contributors need to triage label May 18, 2023
@mathewleeza mathewleeza removed the Needs-Triage New issue that the core contributors need to triage label May 18, 2023
@cinnamon-msft cinnamon-msft transferred this issue from microsoft/devhome May 19, 2023
@cinnamon-msft cinnamon-msft added the Area-Widgets Related to in-package widgets label May 20, 2023
@krschau krschau changed the title [Dashboard][Feature request] turning off GitHub ext should make widget disappear (or something) and not be able to be added [Dashboard][Feature request] Turning off extensions should make widget disappear (or something) and not be able to be added Nov 14, 2023
@krschau krschau removed the Area-Widgets Related to in-package widgets label Nov 14, 2023
@krschau krschau transferred this issue from microsoft/devhomegithubextension Nov 14, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage New issue that the core contributors need to triage label Nov 14, 2023
@krschau
Copy link
Collaborator

krschau commented Nov 14, 2023

Related but not dupe of #1390

@krschau krschau added Area-Extensibility Related to extensions and removed Needs-Triage New issue that the core contributors need to triage labels Nov 14, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Resolution-Duplicate This issue or pull request already exists label Nov 14, 2023
@krschau krschau reopened this Nov 14, 2023
@krschau krschau removed the Resolution-Duplicate This issue or pull request already exists label Nov 14, 2023
@mathewleeza mathewleeza added Issue-Feature New feature or request and removed Issue-Bug Something isn't working or needs investigation labels Nov 20, 2023
@krschau
Copy link
Collaborator

krschau commented Jul 11, 2024

Duplicate of #3252

@krschau krschau marked this as a duplicate of #3252 Jul 11, 2024
@krschau krschau closed this as completed Jul 11, 2024
Copy link
Contributor

We've identified this as a duplicate of another one that already exists. This specific instance is being closed in favor of tracking the concern over on the the linked issue. Please add your 👍 to the other issue to raise its priority. Thanks for your report!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Resolution-Duplicate This issue or pull request already exists label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Extensibility Related to extensions Issue-Feature New feature or request Priority-1 Resolution-Duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants