Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locked file error now crashes Dev Diagnostics #3852

Closed
andreww-msft opened this issue Sep 13, 2024 · 0 comments · Fixed by #3853
Closed

Locked file error now crashes Dev Diagnostics #3852

andreww-msft opened this issue Sep 13, 2024 · 0 comments · Fixed by #3853
Assignees
@timkur
Labels
Area-DD Related to Dev Diagnostics🔍 Issue-Bug Something isn't working or needs investigation Priority-1 Resolution-Fix-Available Available in a release
Milestone
Dev Home v0.18

Comments

@andreww-msft
Copy link
Contributor

andreww-msft commented Sep 13, 2024 •
edited
Loading

Steps to reproduce the bug

  1. Run Dev Diagnostics, and target the ProblemApp2.
  2. Run AnotherApp and lock the shared file.
  3. Goto the Dev Diagnostics Windows Logs page.
  4. In ProblemApp2, hit the Locked File button.
  5. Previously, this created a simple text insight - but this now crashes Dev Diagnostics.

I suspect the problem lies in creating the InsightSimpleTextControl on the wrong thread.
@andreww-msft andreww-msft added Issue-Bug Something isn't working or needs investigation Priority-1 Area-DD Related to Dev Diagnostics🔍 labels Sep 13, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage New issue that the core contributors need to triage label Sep 13, 2024
@andreww-msft andreww-msft removed the Needs-Triage New issue that the core contributors need to triage label Sep 13, 2024
@andreww-msft andreww-msft mentioned this issue Sep 13, 2024
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Sep 13, 2024
@andreww-msft andreww-msft added this to the Dev Home v0.18 milestone Sep 13, 2024
@andreww-msft andreww-msft added the Resolution-Fix-Committed Fix is checked in, but may take 3-4 weeks before it's in a release label Sep 13, 2024
@krschau krschau added Resolution-Fix-Available Available in a release and removed Resolution-Fix-Committed Fix is checked in, but may take 3-4 weeks before it's in a release In-PR This issue has a related PR labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timkur timkur

Labels
Area-DD Related to Dev Diagnostics🔍 Issue-Bug Something isn't working or needs investigation Priority-1 Resolution-Fix-Available Available in a release
Projects
None yet
Milestone
Dev Home v0.18
Development

Successfully merging a pull request may close this issue.

Fix crash in SimpleTextInsights microsoft/devhome
3 participants
@andreww-msft @krschau @timkur